My text-link “button” isn’t showing as a button in the editor — is something wrong?

This is normal. In Edit mode Squarespace shows it as a regular text link; once you Save and exit edit mode, the live page applies the styling and it becomes a button.